Repository navigation
test(live): align V2 integration tests with no product-code pre-checks - #51
Merged
spbsoluble merged 1 commit intoNov 17, 2026
Conversation
PR #50 removed V2's save-time ProductCode catalog check and the single-domain SAN guard, but two live tests still described or asserted them: - V2ApiTests.ValidateProductInfo_V2_RejectsUnknownProductCode expected an unknown code to be rejected at template save. Renamed to ValidateProductInfo_V2_AcceptsUnknownProductCode_WithoutCatalogCheck and now asserts it's accepted; ValidateProductInfo_V2_AcceptsConfiguredProductCode's reason no longer says the code must be in the catalog. - V2FullLifecycleTests.Enroll_V2_WildcardDv_WildcardPlusApexSan_RecordsActualBehavior no longer attributes a FAILED result to the removed guard; it logs the result and cleans up any order created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #50 removed V2's product-code pre-checks: template save no longer looks a
ProductCodeup in the catalog, and enrollment no longer rejects extra SANs with the single-domain guard. Two live integration tests still expected the old behavior. This PR updates them to match.Fixes
V2ApiTests.ValidateProductInfo_V2_RejectsUnknownProductCodeexpected V2 template save to reject an unknown code (999999) with "not found", so it now failed. It's renamed toValidateProductInfo_V2_AcceptsUnknownProductCode_WithoutCatalogCheckand asserts that the code is accepted. V1 still rejects an unknown code when a template is saved.V2ApiTests.ValidateProductInfo_V2_AcceptsConfiguredProductCode: the assertion reason no longer says the code has to be in the catalog.V2FullLifecycleTests.Enroll_V2_WildcardDv_WildcardPlusApexSan_RecordsActualBehavior: a FAILED result is no longer blamed on the removed guard, and the test no longer asserts on the guard's message. It logs the result and cleans up any order that was created. Its doc comment now describes what the plugin actually does: a wildcard's bare apex isn't an extra name, so the request goes out as a single-domain wildcard order.Testing
V2ApiTests.ValidateProductInfo_V2_*: both pass. These are read-only; no order is placed.Other
Targets
feat/v2-consolidated(#39).